Skip to content

Update MANIFEST_TEMPLATE.in.jinja2#30431

Merged
eladkal merged 3 commits intoapache:mainfrom
eladkal:fixup
Apr 4, 2023
Merged

Update MANIFEST_TEMPLATE.in.jinja2#30431
eladkal merged 3 commits intoapache:mainfrom
eladkal:fixup

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Apr 2, 2023

During provider release I noticed several warnnings:

Generated regular package setup files for google
########## Prepare provider package for 'google' ##########
Changing directory to /opt/airflow/provider_packages
Building provider package: google in format both
Executing command: 'python3 setup.py build --build-temp /tmp/tmplaa_85oz egg_info --tag-build sdist bdist_wheel --bdist-dir /tmp/tmpyjwnfmkg'
warning: no files found matching 'airflow/providers/google/cloud/example_dags/*.yaml'
warning: no files found matching 'airflow/providers/google/cloud/example_dags/*.sql'
warning: no files found matching 'CHANGELOG.txt'
warning: no files found matching 'README.md'
warning: no previously-included files matching '__pycache__' found anywhere in distribution
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: build_py: byte-compiling is disabled, skipping.

This PR will address them


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal eladkal marked this pull request as ready for review April 2, 2023 12:39
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For warning: no files found matching 'README.md', we have a readme on only 3 providers:

  • apache beam (not touched since mars 2021)
  • neo4j (empty file)
  • asana (empty file)

Also I don't see where we are using it, IMHO we can delete include README.md too.

@eladkal eladkal merged commit c20f690 into apache:main Apr 4, 2023
@eladkal eladkal deleted the fixup branch April 4, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants