Merged
Conversation
boring-cyborg
bot
added
area:providers
provider:google
pankajastro
force-pushed
the
fix_clean_google_op
branch
from
bd57582 to
07ae837
Compare
pankajastro
force-pushed
the
fix_clean_google_op
branch
from
07ae837 to
3f804ba
Compare
potiuk
approved these changes
Apr 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, in
tests/providers/google/cloud/operators/test_bigquery.pytests are not consistent.Example: some tests for
BigQueryCreateEmptyDatasetOperatorare function based and some tests are class-basedHere, I'm changing all tests to class-based and
remove helper function
create_contextand using fixturecreate_task_instance_of_operator^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.