Better error message where non-compatible providers are not excluded#30629
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 13, 2023
Merged
Conversation
When compatibility check is performed for old version of Airflow, we attempt to install all providers for the old version. However if one of the providers has >= limit on Airflow for newer version of Airflow, this installation lead to attempting to upgrade airflow rather than fail, which could lead to misleading errors. This change adds "airflow==x.y.z" taken from --use-airflow-version flag to the `pip install` command, which should in this case fail with much more accurate message, that the provider conflicts with airflo version.
eladkal
approved these changes
Apr 13, 2023
wookiist
pushed a commit
to wookiist/airflow
that referenced
this pull request
Apr 19, 2023
…pache#30629) When compatibility check is performed for old version of Airflow, we attempt to install all providers for the old version. However if one of the providers has >= limit on Airflow for newer version of Airflow, this installation lead to attempting to upgrade airflow rather than fail, which could lead to misleading errors. This change adds "airflow==x.y.z" taken from --use-airflow-version flag to the `pip install` command, which should in this case fail with much more accurate message, that the provider conflicts with airflo version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compatibility check is performed for old version of Airflow, we attempt to install all providers for the old version. However if one of the providers has >= limit on Airflow for newer version of Airflow, this installation lead to attempting to upgrade airflow rather than fail, which could lead to misleading errors.
This change adds "airflow==x.y.z" taken from --use-airflow-version flag to the
pip installcommand, which should in this case fail with much more accurate message, that the provider conflicts with airflo version.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.