Add postgres_conn_id to template fields in PostgresOperator#30778
Add postgres_conn_id to template fields in PostgresOperator#30778DucNgn wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
hussein-awala
left a comment
There was a problem hiding this comment.
postgres_conn_id is provided to super as conn_id which is already a template field, I'll test it to decide if it already possible or we need to do it in another way
hussein-awala
left a comment
There was a problem hiding this comment.
this can do the job, can you test it?
| """ | ||
|
|
||
| template_fields: Sequence[str] = ("sql",) | ||
| template_fields: Sequence[str] = ("sql", "postgres_conn_id") |
There was a problem hiding this comment.
| template_fields: Sequence[str] = ("sql", "postgres_conn_id") | |
| template_fields: Sequence[str] = ("sql", "conn_id") |
|
BTW, this operator is deprecated: airflow/airflow/providers/postgres/operators/postgres.py Lines 85 to 91 in f20d040 |
|
closing in favor of #30784 |
Add
postgres_conn_idto the template fields for thePostgresOperatorRead the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.