Skip to content

Speed up test collection#30801

Merged
potiuk merged 1 commit intoapache:mainfrom
potiuk:less-delays-on-pytest-collection
Apr 21, 2023
Merged

Speed up test collection#30801
potiuk merged 1 commit intoapache:mainfrom
potiuk:less-delays-on-pytest-collection

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Apr 21, 2023

Test collection had default setting for parallel test types because TEST_TYPES variable had not been renamed to PARALLEL_TEST_TYPES Also test collection can be run in Wait for CI images job which should save around a minute for setting up Breeze and pulling the images.

This should speed up pytest collection test by around 1 and half minute


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk requested review from ashb and kaxil as code owners April 21, 2023 19:37
@potiuk potiuk force-pushed the less-delays-on-pytest-collection branch from 4df2b61 to 25c423b Compare April 21, 2023 19:38
Test collection had default setting for parallel test types because
TEST_TYPES variable had not been renamed to PARALLEL_TEST_TYPES
Also test collection can be run in Wait for CI images job which
should save around a minute for setting up Breeze and pulling the
images.

This should speed up pytest collection test by around 1 and half minute
@potiuk potiuk force-pushed the less-delays-on-pytest-collection branch from 25c423b to 40d1cd6 Compare April 21, 2023 19:39
@potiuk
Copy link
Member Author

potiuk commented Apr 21, 2023

Another small (but noticeable) CI improvement. This one should get the feedback time down by about 1.5 minute for everyone.

@potiuk
Copy link
Member Author

potiuk commented Apr 21, 2023

Yep. 1m40 s. longer "wait for CI images" vs. 4m23s "Test Pytest collection" -> so even more, 2m40s faster feedback time,

@potiuk potiuk merged commit 93a5422 into apache:main Apr 21, 2023
@potiuk potiuk deleted the less-delays-on-pytest-collection branch April 21, 2023 19:49
@eladkal eladkal added this to the Airflow 2.6.2 milestone Jun 9, 2023
@eladkal eladkal added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jun 9, 2023
potiuk added a commit that referenced this pull request Jun 9, 2023
Test collection had default setting for parallel test types because
TEST_TYPES variable had not been renamed to PARALLEL_TEST_TYPES
Also test collection can be run in Wait for CI images job which
should save around a minute for setting up Breeze and pulling the
images.

This should speed up pytest collection test by around 1 and half minute

(cherry picked from commit 93a5422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants