Add providers triggers CLI command in provider discovery#30999
Merged
potiuk merged 2 commits intoapache:mainfrom May 7, 2023
Merged
Add providers triggers CLI command in provider discovery#30999potiuk merged 2 commits intoapache:mainfrom
potiuk merged 2 commits intoapache:mainfrom
Conversation
We added airflow providers triggers command recently. So let's add the same in verify-provider-packages since we run this run in CI so it would make sure that the command is remain healthy.
Member
|
OK. One thing I have not told you of what the providers test does... is it also runs the same tests on Airflow 2.4 to test if providers of ours are installable and discoverable in 2.4 :) - and there the new triggers command is not available... This command used to have conditional removed before that handled it, so you might want to bring it back: This likely shoudl be done better - Ideally you should just import "airflow.version.version" and for commands that were added after the version currently installed, it should skip them from running. |
potiuk
reviewed
May 2, 2023
Member
Author
|
CI job log that discover triggers https://github.com/apache/airflow/actions/runs/4858615847/jobs/8660408477?pr=30999#step:11:2906 |
potiuk
reviewed
May 2, 2023
potiuk
approved these changes
May 2, 2023
pankajastro
force-pushed
the
add_trigger_cmd_in_provider_discovery
branch
from
268eeb3 to
96f4e35
Compare
potiuk
approved these changes
May 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added airflow providers triggers command recently. So let's add the same in verify-provider-packages since we run this run in CI so it would make sure that the command is remain healthy.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.