Remove feature flag for AIP-52#31034
Merged
dstandish merged 2 commits intoapache:mainfrom May 5, 2023
Merged
Conversation
No longer needed because we will complete this for 2.7
dstandish
requested review from
ashb,
ephraimbuddy,
jedcunningham,
kaxil,
potiuk and
uranusjr
as code owners
boring-cyborg
Bot
added
area:dev-tools
provider:cncf-kubernetes
pankajkoti
approved these changes
May 3, 2023
Member
|
Checked out locally and confirmed that all references are removed :) |
| ] | ||
| if _ENABLE_AIP_52: | ||
| expected.insert(1, {"name": "example_setup_teardown_taskflow", "type": "dag"}) | ||
| expected.insert(1, {"name": "example_setup_teardown_taskflow", "type": "dag"}) |
Member
There was a problem hiding this comment.
Let's refactor this, doesn't need to follow this pattern any longer.
ephraimbuddy
approved these changes
May 4, 2023
Member
|
A comment here - I am also cool with it, but it could potentially have some impact on cherry-picking. It' not likely in this case and we will find out when cherry-picking, but just wanted to mention it here. We are likely not going to remove AIP-44 feature flag until very close to the 2.7 branch cut-off for that reason (but our changes are more "core" bound, so just wanted to mention the reasoning here. |
potiuk
approved these changes
May 4, 2023
ephraimbuddy
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer needed because we will complete this for 2.7