Bring back detection of implicit single-line string concatenation#31270
Merged
potiuk merged 1 commit intoapache:mainfrom May 13, 2023
Merged
Conversation
potiuk
requested review from
ashb,
eladkal,
jedcunningham and
o-nikolas
as code owners
boring-cyborg
bot
added
area:dev-tools
area:logging
area:providers
provider:amazon
potiuk
requested review from
dimberman,
dstandish,
ephraimbuddy,
feluelle,
ferruzzi,
hussein-awala,
kaxil and
phanikumv
When we switched to ruff we've lost one of the rules that was useful and is not enabled by default in ruff - detection of implicit single-line string concatenation. It is often automatically introduced by black when reformatting two long strings and it is easy to miss, also it has worse readability so we should bring it back.
potiuk
force-pushed
the
bring-back-detection-of-implicit-string-concatenation
branch
from
a2d4a6e to
5e38c1b
Compare
eladkal
approved these changes
May 13, 2023
hussein-awala
approved these changes
May 13, 2023
feluelle
approved these changes
May 13, 2023
pankajkoti
added a commit
to astronomer/airflow
that referenced
this pull request
May 15, 2023
PR apache#31270 included a minor typo for the word `implicit` in one of its comment. The commit correct the typo from `impocit` to `implicit`.
potiuk
pushed a commit
that referenced
this pull request
May 15, 2023
PR #31270 included a minor typo for the word `implicit` in one of its comment. The commit correct the typo from `impocit` to `implicit`.
ephraimbuddy
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we switched to ruff we've lost one of the rules that was useful and is not enabled by default in ruff - detection of implicit single-line string concatenation.
It is often automatically introduced by black when reformatting two long strings and it is easy to miss, also it has worse readability so we should bring it back.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.