Skip to content

Comments

Update the output of airflow info command in the doc#31336

Merged
potiuk merged 6 commits intoapache:mainfrom
Owen-CH-Leung:update-airflow-info-output
May 18, 2023
Merged

Update the output of airflow info command in the doc#31336
potiuk merged 6 commits intoapache:mainfrom
Owen-CH-Leung:update-airflow-info-output

Conversation

@Owen-CH-Leung
Copy link
Contributor

Update the output of airflow info command

fixes: #31304

Update the output of airflow info command
@Owen-CH-Leung Owen-CH-Leung requested a review from potiuk as a code owner May 17, 2023 03:30
@Owen-CH-Leung Owen-CH-Leung changed the title Update logging-tasks.rst Update the output of airflow info command in the doc May 17, 2023


Providers info
apache-airflow-providers-airbyte | 3.3.0
Copy link
Member

@pankajkoti pankajkoti May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base Airflow does not ship all these providers. Do we want to include this huge list of providers here?
When I create a new virtualenv and install airflow in it, I see only the below providers:

Providers info
apache-airflow-providers-common-sql | 1.4.0
apache-airflow-providers-ftp        | 3.3.1
apache-airflow-providers-http       | 4.3.0
apache-airflow-providers-imap       | 3.1.1
apache-airflow-providers-sqlite     | 3.3.2

It looks like like this list includes the providers that are additionally installed in your setup. Additionally, apache-airflow-providers-yandex is suspended but we're still showing it here.

So in my opinion, it would be good to curtail this list to only the providers that are shipped with base Airflow.
We can wait for what others have to say.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I got all these providers because I'm fetching the outputs from breeze start-airflow which includes everything I guess. I've shortened the outputs and only keep the logging part

@uranusjr
Copy link
Member

Since this section of the documentation is just about debugging logging configurations, it may be a good idea to only include the first section of the output since the rest of the output is not particularly relevant (and add a note describing the reasoning to this omission)

@Owen-CH-Leung
Copy link
Contributor Author

Since this section of the documentation is just about debugging logging configurations, it may be a good idea to only include the first section of the output since the rest of the output is not particularly relevant (and add a note describing the reasoning to this omission)

Sure. I've modified the file to only include the first section and added a short note to explain


[skipping the remaining outputs for brevity]

The output of ``airflow info`` is huge so we only keep those that are relevant to logging configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The output of ``airflow info`` is huge so we only keep those that are relevant to logging configuration.
The output of `airflow info` above is truncated to only display the section that pertains to the logging configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pankajkoti . Adopted your suggested changes =D

@potiuk potiuk merged commit fc4f37b into apache:main May 18, 2023
@Owen-CH-Leung Owen-CH-Leung deleted the update-airflow-info-output branch May 18, 2023 10:29
@eladkal eladkal added the type:doc-only Changelog: Doc Only label Jun 8, 2023
@eladkal eladkal added this to the Airflow 2.6.2 milestone Jun 8, 2023
eladkal pushed a commit that referenced this pull request Jun 8, 2023
* Update logging-tasks.rst

Update the output of airflow info command

* Update logging-tasks.rst

* Update logging-tasks.rst

* Fix failing static check

(cherry picked from commit fc4f37b)
eladkal pushed a commit that referenced this pull request Jun 9, 2023
* Update logging-tasks.rst

Update the output of airflow info command

* Update logging-tasks.rst

* Update logging-tasks.rst

* Fix failing static check

(cherry picked from commit fc4f37b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated 'airflow info' output in Logging for Tasks page

5 participants