Skip to content

[AIRFLOW-2227] allow the ability to delete an airflow variable using the variable class #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nadav-baruryan-lmnd wants to merge 4 commits into from
Closed

[AIRFLOW-2227] allow the ability to delete an airflow variable using the variable class #3142

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
288a9e5
new delete and get keys to ariflow variable class
Mar 19, 2018
2f8fdac
new delete and get keys to ariflow variable class
Mar 19, 2018
f9fddb1
fix indentation
Mar 20, 2018
631c2a3
fixed from general variable to use the actual class
Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions airflow/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4285,6 +4285,27 @@ def set(cls, key, value, serialize_json=False, session=None):
session.add(Variable(key=key, val=stored_value))
session.flush()

@classmethod
@provide_session
def delete(cls, key, session=None):
try:
session.query(cls).filter(cls.key == key).delete()
session.commit()
Copy link
Member

@ashb ashb May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems suspect - why do we want to commit the session here - shouldn't the caller be in change of the session instead?

except Exception as e:
session.rollback()
logging.warning("Failed to delete key {}".format(key))
Copy link
Member

@ashb ashb May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"variable", not key.

logging.exception(e)

@classmethod
@provide_session
def get_keys(cls, session=None):
Copy link
Member

@ashb ashb May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this method for?

try:
keys = {obj.key for obj in session.query(cls).all()}
return keys
except Exception as e:
logging.warning("Failed to retrieve variables keys")
logging.exception(e)


class XCom(Base, LoggingMixin):
"""
Expand Down