Fix deletion of Airflow source dir in virtualenv installation script#31653
Merged
hussein-awala merged 2 commits intoapache:mainfrom Jun 1, 2023
Merged
Conversation
uranusjr
reviewed
Jun 1, 2023
uranusjr
approved these changes
Jun 1, 2023
uranusjr
reviewed
Jun 1, 2023
| """ | ||
| airflow_home_dir = Path(os.environ.get("AIRFLOW_HOME", Path.home() / "airflow")) | ||
| airflow_sources = Path(__file__).parents[2] | ||
| airflow_sources = Path(__file__).resolve().parents[2] |
Member
There was a problem hiding this comment.
I was thinking if airflow_sources = Path(__file__).parents[2].resolve() is better, but it probably does not matter either way sicne we control the scripts/tools directory and there’s very unlikely any non-regular entries (e.g. symlinks).
hussein-awala
approved these changes
Jun 1, 2023
Member
|
The failed tests are not related to this PR and they will be fixed by #31664 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was following the contributors quick start guide and my source directory kept getting deleted when running this command:
./scripts/tools/initialize_virtualenv.pyMy source directory happened to be
$HOME/airflow. With this fix, at least the check ifairflow_home_dir == airflow_sourcesworks again.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.