[AIRFLOW-2281] Add support for Sendgrid categories #3188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3188 +/- ##
==========================================
- Coverage 74.21% 74.14% -0.08%
==========================================
Files 193 193
Lines 14433 14433
==========================================
- Hits 10712 10701 -11
- Misses 3721 3732 +11
Continue to review full report at Codecov.
|
Contributor
|
I see you've refactored the existing tests. Please keep the original tests and add one with categories. So we test both cases, (1) without any categories given, (2) with explicit categories. |
Contributor
Author
|
Both cases are tested. No categories case is handled by the existing test
case 'test_send_email_sendgrid_correct_email'. I decided to merge the test
case for categories into personalizations, cause they use the same kwargs
mechanism and can be tested together.
…On Mon, Apr 9, 2018, 09:07 Fokko Driesprong ***@***.***> wrote:
I see you've refactored the existing tests. Please keep the original tests
and add one with categories. So we test both cases, (1) without any
categories given, (2) with explicit categories.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3188 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE03eSS_8-YrRN3ufnbL8HmdEdg985vwks5tmxazgaJpZM4THdv8>
.
|
Contributor
|
Ok @ms32035 Thanks for the explanation. |
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
Closes apache#3188 from ms32035/sendgrid_categories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
Description
Tests
Commits
My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Passes
git diff upstream/master -u -- "*.py" | flake8 --diff