Skip to content

Fix a couple Airflow release doc errors#31951

Merged
jedcunningham merged 1 commit into
apache:mainfrom
astronomer:release_docs_fixup
Jun 22, 2023
Merged

Fix a couple Airflow release doc errors#31951
jedcunningham merged 1 commit into
apache:mainfrom
astronomer:release_docs_fixup

Conversation

@jedcunningham
Copy link
Copy Markdown
Member

No description provided.

Comment thread dev/README_RELEASE_AIRFLOW.md
Copy link
Copy Markdown
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please mention the context of why we are doing this(in the description), is it because the last time RC packaging wasn't correct ?

Comment thread dev/README_RELEASE_AIRFLOW.md
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Jun 16, 2023

Approved with the command restoring :)

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Jun 16, 2023

can you please mention the context of why we are doing this(in the description), is it because the last time RC packaging wasn't correct ?

We usually place little context in case we correct those instructions @phanikumv :). The thing which such instructions (which you learn when you start doing release manager duty) is that pretty much every-single-time (TM) when you follow such instructions you find typos and mistakes, and changed circumstances that made previous instructions slightly wrong.

This means that every time the context wil be "Found those small typoes with last iteration of following the process". There are possibly tens or hundreds similar commits in the past :).

This is more-or-less fact of life we have to deal with until you just make it part of a fully automated CI/release process (in which case also things stop working occasionally and you need to fix it occasionally).

The good thing is that I hope in about 6-8 months the ASF will have a way to automate some of the release process so that we do not have to do it manually on "release-manager exclusively administered machines" (currently this is a requirement by the ASF) and hopefully, we will be able to make it more of trigger in a CI that we will keep on running on a daily basis.

@phanikumv
Copy link
Copy Markdown
Contributor

can you please mention the context of why we are doing this(in the description), is it because the last time RC packaging wasn't correct ?

We usually place little context in case we correct those instructions @phanikumv :). The thing which such instructions (which you learn when you start doing release manager duty) is that pretty much every-single-time (TM) when you follow such instructions you find typos and mistakes, and changed circumstances that made previous instructions slightly wrong.

This means that every time the context wil be "Found those small typoes with last iteration of following the process". There are possibly tens or hundreds similar commits in the past :).

This is more-or-less fact of life we have to deal with until you just make it part of a fully automated CI/release process (in which case also things stop working occasionally and you need to fix it occasionally).

The good thing is that I hope in about 6-8 months the ASF will have a way to automate some of the release process so that we do not have to do it manually on "release-manager exclusively administered machines" (currently this is a requirement by the ASF) and hopefully, we will be able to make it more of trigger in a CI that we will keep on running on a daily basis.

Thank you Jarek, makes more sense to me now :)

Copy link
Copy Markdown
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that my first review was a comment and not an approve

@jedcunningham jedcunningham merged commit 5a4106d into apache:main Jun 22, 2023
@jedcunningham jedcunningham deleted the release_docs_fixup branch June 22, 2023 00:52
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants