[AIRFLOW-2312] Docs Typo Correction: Corresponding #3211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# JIRA [x] My PR addresses the following Airflow JIRA issues and references them in the PR title. * https://issues.apache.org/jira/browse/AIRFLOW-2312 # Description [x] Here are some details about my PR Minor typo fix in the docs. `correpsonding` to `corresponding` # Tests [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: I assume I don't need testing for docs # Commits [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how"
Contributor
|
Thanks for spotting! 👍 |
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
# JIRA [x] My PR addresses the following Airflow JIRA issues and references them in the PR title. * https://issues.apache.org/jira/browse/AIRFLOW-2312 # Description [x] Here are some details about my PR Minor typo fix in the docs. `correpsonding` to `corresponding` # Tests [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: I assume I don't need testing for docs # Commits [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" Closes apache#3211 from tamsanh/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
Description
correpsondingtocorrespondingTests
Assuming don't need tests for simple doc change
Commits
My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Passes
git diff upstream/master -u -- "*.py" | flake8 --diff