Skip to content

Conversation

@sdiazb
Copy link
Contributor

@sdiazb sdiazb commented Apr 11, 2018

Dear Airflow maintainers,

Please accept this PR.

JIRA

Description

  • SFTP Sensor.
    This PR leverages the SFTPHook created in AIRFLOW-442 that should be merged before this PR.

Tests

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@sdiazb
Copy link
Contributor Author

sdiazb commented Apr 11, 2018

@Fokko I've opened again the old PR to force the build. I think everything is ready to be merged now. Many thanks for your help.

@Fokko
Copy link
Contributor

Fokko commented Apr 12, 2018

LGTM, Thanks @sdiazb for adding the tests.

@asfgit asfgit closed this in bc6feea Apr 12, 2018
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants