[AIP-49] Fix task_instance_created metric name#32156
Merged
potiuk merged 1 commit intoapache:mainfrom Jun 27, 2023
Merged
Conversation
Both StatsD and OTel replace the hyphen in the name with an underscore. A user looking for `task_instance_created-<operator_name>` would not find it and may not think to look for `task_instance_created_<operator_name>`. Also updated related test logic and docs to make that more obvious.
potiuk
approved these changes
Jun 27, 2023
ferruzzi
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 27, 2023
Both StatsD and OTel replace the hyphen in the name with an underscore. A user looking for `task_instance_created-<operator_name>` would not find it and may not think to look for `task_instance_created_<operator_name>`. Also updated related test logic and docs to make that more obvious.
ephraimbuddy
added
AIP-49
changelog:skip
ferruzzi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both StatsD and OTel replace the hyphen in the name with an underscore. A user looking for
task_instance_created-<operator_name>would not find it and may not think to look fortask_instance_created_<operator_name>. Also updated related test logic and docs to make that more obvious.Since both metrics backends make this name change behind the scenes anyway, I don't feel thins needs a deprecation period; nothing should visibly change to the user. If someone feels otherwise, I can roll this back and just update the rst file to make it more obvious instead.