Fix BigQuery transfer operators to respect project_id arguments#32232
Merged
potiuk merged 13 commits intoapache:mainfrom Jul 6, 2023
Merged
Fix BigQuery transfer operators to respect project_id arguments#32232potiuk merged 13 commits intoapache:mainfrom
potiuk merged 13 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Member
|
LGTM. Is it possible to add test ? and @Yaro1 -> are you ok with it? |
potiuk
approved these changes
Jun 29, 2023
Closed
2 tasks
Member
|
Static checks need fixing + rebase. |
Contributor
|
Lets please fix all occurrences as mentioned in #32106 (comment) |
Contributor
Author
|
@eladkal Sure, that makes sense. Working on merging all the fixes into this PR. |
…s project_id is the only fallback if table project is not specified.
Contributor
Author
Member
|
Tests are failing. |
This was referenced Jul 6, 2023
eladkal
approved these changes
Jul 6, 2023
potiuk
approved these changes
Jul 6, 2023
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Closed
2 tasks
Contributor
|
Congrats on this, and my thanks! |
Contributor
|
Yes, many thanks from my side too! |
syedahsn
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 11, 2023
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While submitting the BigQuery to GCS job or GCS to BigQuery job, the current code only prefers the project_id of the BigQuery table, and ignores the provided project_id argument to the
BigQueryToGCSOperatorandGCSToBigQueryOperatoroperators (as pointed out by @bhagany in #32106). This is not the expected behaviour, and the provided project_id must be used to submit the job to BigQuery and use that project's resources for computation.This change aims to correct this behaviour by making hook's project_id as the fallback project for both BigQuery storage and compute.
Note: This change replaces @Yaro1 's previous change in #30053, where the BQ table's project_id is used for computation.
closes: #32106
suppress: #32144
suppress: #32143
suppress: #32095