Skip to content

Conversation

@guiligan
Copy link

Make sure you have checked all steps below.

JIRA

  • My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@r39132
Copy link
Contributor

r39132 commented Apr 13, 2018

@guiligan you need to create a JIRA for documentation-only updates as well. Also, why did you update 2 companies on the list?

@r39132
Copy link
Contributor

r39132 commented Apr 13, 2018

Also, you do need to fill out the template..

@r39132
Copy link
Contributor

r39132 commented Apr 20, 2018

#3242 handles this.. I'll close this for inactivity!

@r39132
Copy link
Contributor

r39132 commented Apr 20, 2018

@asfgit asfgit closed this in e614578 Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants