Allow class name to have leading underscores#32478
Merged
uranusjr merged 1 commit intoapache:mainfrom Jul 10, 2023
Merged
Conversation
utkarsharma2
approved these changes
Jul 10, 2023
Adaverse
reviewed
Jul 10, 2023
Contributor
Adaverse
left a comment
Adaverse
left a comment
There was a problem hiding this comment.
Just appending the error with more helpful info
uranusjr
force-pushed
the
provider-class-name-allow-leading-underscore
branch
from
7d158f4 to
de15420
Compare
potiuk
approved these changes
Jul 10, 2023
Member
Author
|
Failures are unrelated and should be fixed by #32489. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#32475 was not enough to fix main 🥲