Do not fail when docker context cannot be used#32497
Merged
potiuk merged 1 commit intoapache:mainfrom Jul 10, 2023
Merged
Conversation
This is a follow-up after apache#32494 and apache#32463, where autodetection of docker context has been added. There is a weird relation between builders and docker context - sometimes they have to be used in sync, and sometimes not. For example when we are creating a new context manually (airxflow_cache) to build images in parallel on ARM/x86, we should use airflow_cache as buider, but the context should remain "default". On the other hand when we are using "desktop-linux" builder, we MUST switch the context to "desktop-linux". This PR is an attempt to make best effort to switch to the same context as the builder, but instead of failing, we just warn if can't and continue.
jedcunningham
approved these changes
Jul 10, 2023
hussein-awala
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up after #32494 and #32463, where autodetection of docker context has been added. There is a weird relation between builders and docker context - sometimes they have to be used in sync, and sometimes not. For example when we are creating a new context manually (airxflow_cache) to build images in parallel on ARM/x86, we should use airflow_cache as buider, but the context should remain "default". On the other hand when we are using "desktop-linux" builder, we MUST switch the context to "desktop-linux".
This PR is an attempt to make best effort to switch to the same context as the builder, but instead of failing, we just warn if can't and continue.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.