EMR serverless Create/Start/Stop/Delete Application deferrable mode#32513
Merged
o-nikolas merged 8 commits intoapache:mainfrom Jul 24, 2023
Merged
Conversation
Contributor
Author
|
@uranusjr @pragnareddye @vandonr-amz Can you please have another look at this PR? This is the same PR as #32414 - I ended up closing that because there was a problem with rebasing which messed up the commits 😅 This PR is the same one - I've addressed all comments. Please let me know if I've missed anything |
Contributor
|
I left some comments on the previous PR that I don't think you addressed ? Maybe you can reply where I left them ? |
syedahsn
commented
Jul 12, 2023
syedahsn
commented
Jul 12, 2023
Lee-W
reviewed
Jul 17, 2023
Lee-W
reviewed
Jul 20, 2023
230fdfc to
50d52d7
Compare
Lee-W
approved these changes
Jul 24, 2023
o-nikolas
approved these changes
Jul 24, 2023
69 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds deferrable mode to
EmrServerlessCreateApplicationOperator,EmrServerlessStopApplicationOperator, andEmrServerlessDeleteApplicationOperator. All the associated tests are included.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.