Skip to content

[AIRFLOW-2404] Add additional documentation for unqueued task#3286

Closed
AetherUnbound wants to merge 1 commit intoapache:masterfrom
AllenInstitute:feature/task-not-queued-doc
Closed

[AIRFLOW-2404] Add additional documentation for unqueued task#3286
AetherUnbound wants to merge 1 commit intoapache:masterfrom
AllenInstitute:feature/task-not-queued-doc

Conversation

@AetherUnbound
Copy link
Contributor

@AetherUnbound AetherUnbound commented May 1, 2018

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    • I've added some additional explanation as to why a task might not have started. This came about as we were trying to understand why our scheduler wasn't queueing more DAG runs
      airflow

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    • This is a documentation change and does not need unit tests

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@AetherUnbound AetherUnbound force-pushed the feature/task-not-queued-doc branch from 5ec93c7 to a4178ed Compare May 1, 2018 19:47
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AetherUnbound Improvements on documentation are highly appreciated.

@codecov-io
Copy link

Codecov Report

Merging #3286 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3286   +/-   ##
======================================
  Coverage    75.9%   75.9%           
======================================
  Files         197     197           
  Lines       14702   14702           
======================================
  Hits        11159   11159           
  Misses       3543    3543
Impacted Files Coverage Δ
airflow/www/views.py 71.41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67c13e...a4178ed. Read the comment docs.

@AetherUnbound
Copy link
Contributor Author

No worries! This should be ready @Fokko

@asfgit asfgit closed this in 9a0c4e6 May 2, 2018
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
Closes apache#3286 from AetherUnbound/feature/task-not-
queued-doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants