Order the release commands properly#32888
Conversation
|
I don’t think this will have much effect. Git tagging is done as part of the breeze release command earlier than this |
|
Can you point me to it @pierrejeambrun? I can fix it if thats the case |
|
It's done by the following command, earlier in the process: The source for the command is here, the |
|
Thanks Pierre. Can you point me to what you think is the issue? I can pick it up |
|
As I understand the reported issue, an idea would be to update the dockerfile airflow version when we upgrade the airflow version in the test-branch. (update This way the tag will have the appropriate version in the dockerfile. We already have a line: For updating version in main, we also need this in the test branch I think |
|
Yes. @amoghrajesh. Again - as I suggested before - you can try to PERFORM release process by following the guide and then you will see. what is going on and where you need to fix it. If you are attempting to fix it without actually following the release process, you are attempting to fix something theorethical. The ONLY way to improve the release process is to follow it yourself and find the place where to fix it. This is pretty much an imperative. You really need to experience what's going on if you want to fix it. You will not be able to push or publish the packages, but all the rest you will be able to do it with your own hands - otherwise you will make changes like the last time where you misunderstood what you need to do. |
|
Thanks for that @potiuk But from your comment, it looks like I can try out the rest of the stuff at the very least. Will be mindful of it and try it out. Apologies for the confusion the last time |
closes: #32877
Due to the documentation, updating the version is done after the TAG is set for the release. We should re order it
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.