Skip to content

Comments

Order the release commands properly#32888

Merged
uranusjr merged 1 commit intoapache:mainfrom
amoghrajesh:releaseDocFix
Jul 28, 2023
Merged

Order the release commands properly#32888
uranusjr merged 1 commit intoapache:mainfrom
amoghrajesh:releaseDocFix

Conversation

@amoghrajesh
Copy link
Contributor

@amoghrajesh amoghrajesh commented Jul 27, 2023

closes: #32877

Due to the documentation, updating the version is done after the TAG is set for the release. We should re order it


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@uranusjr uranusjr changed the title Ordering the release command properly Order the release commands properly Jul 28, 2023
@uranusjr uranusjr merged commit 7ba7fb1 into apache:main Jul 28, 2023
@pierrejeambrun
Copy link
Member

I don’t think this will have much effect. Git tagging is done as part of the breeze release command earlier than this

@amoghrajesh
Copy link
Contributor Author

Can you point me to it @pierrejeambrun?

I can fix it if thats the case

@pierrejeambrun
Copy link
Member

It's done by the following command, earlier in the process:

breeze release-management start-rc-process ...

The source for the command is here, the git_tag fn.

@amoghrajesh
Copy link
Contributor Author

Thanks Pierre.

Can you point me to what you think is the issue? I can pick it up

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jul 28, 2023

As I understand the reported issue, an idea would be to update the dockerfile airflow version when we upgrade the airflow version in the test-branch. (update airflow/__init__.py, airflow/api_connexion/openapi/v1.yaml, just before building the release note and running the breeze start-rc-process).

This way the tag will have the appropriate version in the dockerfile.

We already have a line:

Updating Dockerfile with the new version.

For updating version in main, we also need this in the test branch I think

@potiuk
Copy link
Member

potiuk commented Jul 28, 2023

Yes. @amoghrajesh. Again - as I suggested before - you can try to PERFORM release process by following the guide and then you will see. what is going on and where you need to fix it. If you are attempting to fix it without actually following the release process, you are attempting to fix something theorethical. The ONLY way to improve the release process is to follow it yourself and find the place where to fix it. This is pretty much an imperative. You really need to experience what's going on if you want to fix it.

You will not be able to push or publish the packages, but all the rest you will be able to do it with your own hands - otherwise you will make changes like the last time where you misunderstood what you need to do.

@amoghrajesh
Copy link
Contributor Author

Thanks for that @potiuk
I didn't try to experience it this time because it looked like I didn't have rights to create or push packages.

But from your comment, it looks like I can try out the rest of the stuff at the very least. Will be mindful of it and try it out.

Apologies for the confusion the last time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong version in Dockerfile

6 participants