Raise original import error in CLI vending of executors#32931
Merged
potiuk merged 1 commit intoapache:mainfrom Jul 29, 2023
Merged
Raise original import error in CLI vending of executors#32931potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
Small follow-up after apache#29055 - for better diagnostic of potential future problems, it would be good to re-raise the original import error, otherwise if the Import error results from some other issue than Airflow version, we will get quite a bit of head scratching trying to diagnose some of the resulting aftermath.
boring-cyborg
Bot
added
provider:cncf-kubernetes
eladkal
approved these changes
Jul 29, 2023
Member
Author
|
cc: @o-nikolas -> very small update to your PR :) |
Member
Author
|
Random/flaky test issues. Merging. |
69 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up after #29055 - for better diagnostic of potential future problems, it would be good to re-raise the original import error, otherwise if the Import error results from some other issue than Airflow version, we will get quite a bit of head scratching trying to diagnose some of the resulting aftermath.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.