Skip to content

Comments

fix: front dagview - explicit wording - next run#32964

Merged
bbovenzi merged 1 commit intoapache:mainfrom
raphaelauv:fix/front_dagview_explicit_wording
Feb 20, 2024
Merged

fix: front dagview - explicit wording - next run#32964
bbovenzi merged 1 commit intoapache:mainfrom
raphaelauv:fix/front_dagview_explicit_wording

Conversation

@raphaelauv
Copy link
Contributor

All airflow new users are struggling with the concept of dag_run and execution date

I found myself explaining many time what mean "next run" on the UI

I think this change explicit what it mean for the end users

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 31, 2023
@bbovenzi
Copy link
Contributor

bbovenzi commented Aug 1, 2023

This is why we added a tooltip to give more information. Is there something else you'd like here?

Screenshot 2023-08-01 at 10 50 53 AM

@raphaelauv
Copy link
Contributor Author

users reading next run followed by a date, will always think that is the date of when the next dag_run will occur.

The information of the tooltip appear contradictory with the next run field for the users.

Also the next run field of the dag page do not have a
image

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 16, 2023
@raphaelauv
Copy link
Contributor Author

up

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 17, 2023
@github-actions
Copy link

github-actions bot commented Nov 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 6, 2023
@raphaelauv
Copy link
Contributor Author

Up

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 8, 2023
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually changed my mind. ID isn't accurate either I'd prefer something like Next Run Interval, but that is also a lot to fit in the view.

@github-actions
Copy link

github-actions bot commented Jan 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 3, 2024
@raphaelauv
Copy link
Contributor Author

the next run value show is the next_run id

image

so it's more explicit to name it next_run_id than just next_run

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 5, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 20, 2024
@bbovenzi bbovenzi added this to the Airflow 2.8.2 milestone Feb 20, 2024
@bbovenzi bbovenzi merged commit 43e4e3d into apache:main Feb 20, 2024
@ephraimbuddy ephraimbuddy removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 22, 2024
@ephraimbuddy ephraimbuddy added type:bug-fix Changelog: Bug Fixes changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:bug-fix Changelog: Bug Fixes labels Feb 22, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
@raphaelauv raphaelauv deleted the fix/front_dagview_explicit_wording branch June 3, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants