Avoid upgrade-to-newer-dependencies when provider.yaml changes#33082
Merged
potiuk merged 1 commit intoapache:mainfrom Aug 3, 2023
Merged
Conversation
The "upgrade-to-newer-dependencies" has been triggered when provider.yaml changed, but this was completely unnecessary. The real reason for upgrade is only when generated/provider_dependencies.json changes - because that is what changes dependencies used. The provider_dependencies.json is automatically updated during pre-commit based on provider.yaml files, so only using it to trigger --upgrade-to-newer-dependencies is enough.
potiuk
requested review from
amoghrajesh,
eladkal,
ephraimbuddy,
hussein-awala,
pankajastro and
pankajkoti
hussein-awala
approved these changes
Aug 3, 2023
amoghrajesh
approved these changes
Aug 3, 2023
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Interesting find. The fix looks good +1
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 4, 2023
The "upgrade-to-newer-dependencies" has been triggered when provider.yaml changed, but this was completely unnecessary. The real reason for upgrade is only when generated/provider_dependencies.json changes - because that is what changes dependencies used. The provider_dependencies.json is automatically updated during pre-commit based on provider.yaml files, so only using it to trigger --upgrade-to-newer-dependencies is enough. (cherry picked from commit 825a818)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "upgrade-to-newer-dependencies" has been triggered when provider.yaml changed, but this was completely unnecessary. The real reason for upgrade is only when
generated/provider_dependencies.json changes - because that is what changes dependencies used.
The provider_dependencies.json is automatically updated during pre-commit based on provider.yaml files, so only using it to trigger --upgrade-to-newer-dependencies is enough.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.