Skip to content

openlineage: remove eager test for auth headers, fix example dag #33087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Aug 3, 2023
Merged

openlineage: remove eager test for auth headers, fix example dag #33087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airflow/example_dags/plugins/event_listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def on_task_instance_failed(previous_state: TaskInstanceState, task_instance: Ta

# [START howto_listen_dagrun_success_task]
@hookimpl
def on_dag_run_success(dag_run: DagRun, message: str):
def on_dag_run_success(dag_run: DagRun, msg: str):
"""
This method is called when dag run state changes to SUCCESS.
"""
Expand All @@ -126,7 +126,7 @@ def on_dag_run_success(dag_run: DagRun, message: str):

# [START howto_listen_dagrun_failure_task]
@hookimpl
def on_dag_run_failed(dag_run: DagRun, message: str):
def on_dag_run_failed(dag_run: DagRun, msg: str):
"""
This method is called when dag run state changes to FAILED.
"""
Expand All @@ -142,7 +142,7 @@ def on_dag_run_failed(dag_run: DagRun, message: str):

# [START howto_listen_dagrun_running_task]
@hookimpl
def on_dag_run_running(dag_run: DagRun, message: str):
def on_dag_run_running(dag_run: DagRun, msg: str):
"""
This method is called when dag run state changes to RUNNING.
"""
Expand Down
3 changes: 0 additions & 3 deletions tests/providers/openlineage/plugins/test_openlineage_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def test_create_client_from_ol_env():

assert client.transport.url == "http://ol-api:5000"
assert "Authorization" in client.transport.session.headers
assert client.transport.session.headers["Authorization"] == "Bearer api-key"


@conf_vars(
Expand All @@ -57,8 +56,6 @@ def test_create_client_from_config_with_options():

assert client.transport.kind == "http"
assert client.transport.url == "http://ol-api:5000"
assert "Authorization" in client.transport.session.headers
assert client.transport.session.headers["Authorization"] == "Bearer api-key"


@conf_vars(
Expand Down