Skip to content

Fix xcom view returning bytes as xcom value#33202

Merged
uranusjr merged 1 commit intoapache:mainfrom
astronomer:fix-xcom-return-val
Aug 8, 2023
Merged

Fix xcom view returning bytes as xcom value#33202
uranusjr merged 1 commit intoapache:mainfrom
astronomer:fix-xcom-return-val

Conversation

@ephraimbuddy
Copy link
Contributor

XCom.value is a LargeBinary column type and making a select/query directly on a LargeBinary column results in SQLALchemy returning byte data. This commit fixes this issue that resulted in xcom value displayed as byte data in the UI

XCom.value is a LargeBinary column type and making a select/query directly
on a LargeBinary column results in SQLALchemy returning byte data.
This commit fixes this issue that resulted in xcom value displayed as byte data in the UI
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 8, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.0 milestone Aug 8, 2023
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Aug 8, 2023
@ephraimbuddy
Copy link
Contributor Author

The problem:
Screenshot 2023-08-08 at 12 53 02

@uranusjr
Copy link
Member

uranusjr commented Aug 8, 2023

What was the change that broke this?

@ephraimbuddy
Copy link
Contributor Author

What was the change that broke this?

I think after this change: #31661, it wasn't returning value then this :#31807 fixed it but introduced the bytes

@uranusjr
Copy link
Member

uranusjr commented Aug 8, 2023

Thanks, that makes sense.

@uranusjr uranusjr merged commit 36c2735 into apache:main Aug 8, 2023
@uranusjr uranusjr deleted the fix-xcom-return-val branch August 8, 2023 14:50
ephraimbuddy added a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants