Merge system tests for CloudSQLExportInstanceOperator into one test#33315
Merged
potiuk merged 1 commit intoapache:mainfrom Aug 13, 2023
Merged
Merge system tests for CloudSQLExportInstanceOperator into one test#33315potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
boring-cyborg
Bot
added
area:providers
area:system-tests
kind:documentation
provider:google
Lee-W
reviewed
Aug 12, 2023
|
|
||
| INSTANCE_NAME = f"{DAG_ID}-{ENV_ID}-instance" | ||
| DB_NAME = f"{DAG_ID}-{ENV_ID}-db" | ||
| INSTANCE_NAME = f"{DAG_ID}-{ENV_ID}-instance".replace("_", "-") |
Member
There was a problem hiding this comment.
May I know why do we need these replace("_", "-"). It seems to be {DAG_ID}-{ENV_ID}-instance on the deferrable side as well
Member
There was a problem hiding this comment.
Thre cannot be _ in the instance name I believe (and I think the change to deferrable is coming as well :)
Contributor
Author
There was a problem hiding this comment.
Thank you for taking a look on this PR!
You are right, the name of the instance is valid only if consists of dashes and letters only, in this case.
As this PR combines 2 system tests into one, the deferrable and sync mode are combined in one file, so created instance will be used in both cases (def and sync)
potiuk
approved these changes
Aug 13, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr merges 2 system tests for CloudSQL into one.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.