[AIRFLOW-2016] assign template_fields for Dataproc Workflow Template sub-classes#3346
Closed
mchalek wants to merge 1 commit intoapache:masterfrom
Closed
[AIRFLOW-2016] assign template_fields for Dataproc Workflow Template sub-classes#3346mchalek wants to merge 1 commit intoapache:masterfrom
mchalek wants to merge 1 commit intoapache:masterfrom
Conversation
sub-classes, not base class
Contributor
|
+@fenglu-g Looks like I applied templates incorrectly |
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
sub-classes, not base class Closes apache#3346 from mchalek/mchalek-fix-inline- workflow-template-operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
In those comments I confirmed with the original submitter for that ticket, @DanSedov , that the existing code has a problem and that it is correctly addressed by this commit.
Description
template_fieldsfor the DataProc WorkflowTemplate operators out of the base operator and into the derived classes. This is necessary because the derived classes only use subsets of the templated fields, and so when task instances are instantiated for them, errors are thrown for the fields that are missing.Tests
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff