Automatically update the REVISIONS_HEADS_MAP in db.py#33616
Merged
ephraimbuddy merged 6 commits intoAug 22, 2023
Conversation
ephraimbuddy
requested review from
ashb,
kaxil,
pierrejeambrun and
potiuk
as code owners
potiuk
reviewed
Aug 22, 2023
This has been the responsibility of the release manager and manually done. In 2.7.0, I mistakenly added a wrong value for the revision which means that anyone upgrading with `airflow db migrate --version 2.7.0` will end up having incorrect migration. This PR automates this and always updates it to the correct value through pre-commit
ephraimbuddy
force-pushed
the
automate_revisions_head_map
branch
from
3bb1c4e to
f41ab17
Compare
ephraimbuddy
force-pushed
the
automate_revisions_head_map
branch
from
052e986 to
c526961
Compare
potiuk
approved these changes
Aug 22, 2023
jedcunningham
approved these changes
Aug 22, 2023
potiuk
approved these changes
Aug 22, 2023
jedcunningham
approved these changes
Aug 22, 2023
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
added a commit
that referenced
this pull request
Aug 28, 2023
* Automatically update the REVISIONS_HEADS_MAP in db.py This has been the responsibility of the release manager and manually done. In 2.7.0, I mistakenly added a wrong value for the revision which means that anyone upgrading with `airflow db migrate --version 2.7.0` will end up having incorrect migration. This PR automates this and always updates it to the correct value through pre-commit * fixup! Automatically update the REVISIONS_HEADS_MAP in db.py * Account for missing versions in revision heads map * Provide the full path of the DB file in message * Make REVISION_HEADS_MAP private * Only add from 2.0.0 up (cherry picked from commit 513c1d2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been the responsibility of the release manager and is manually done. In 2.7.0, I mistakenly added a wrong value for the revision which means that anyone upgrading with
airflow db migrate --version 2.7.0will end up having incorrect migration.This PR automates this and always updates it to the correct value through pre-commit