Skip to content

[AIRFLOW-XXX] Add AdBOOST in user list#3362

Closed
matejkloska wants to merge 1 commit intoapache:masterfrom
matejkloska:patch-1
Closed

[AIRFLOW-XXX] Add AdBOOST in user list#3362
matejkloska wants to merge 1 commit intoapache:masterfrom
matejkloska:patch-1

Conversation

@matejkloska
Copy link
Contributor

Add AdBOOST in user list

Make sure you have checked all steps below.

JIRA

  • My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@msumit
Copy link
Contributor

msumit commented May 15, 2018

@matejkloska plz update the commit msg to just Add AdBOOST in user list

@matejkloska
Copy link
Contributor Author

@msumit hope now it's fine.

@codecov-io
Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #3362 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3362      +/-   ##
==========================================
+ Coverage   76.44%   76.45%   +<.01%     
==========================================
  Files         203      203              
  Lines       15002    15002              
==========================================
+ Hits        11469    11470       +1     
+ Misses       3533     3532       -1
Impacted Files Coverage Δ
airflow/models.py 86.83% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e5ae96...53b5210. Read the comment docs.

@asfgit asfgit closed this in eb99401 May 15, 2018
Currently **officially** using Airflow:

1. [Airbnb](http://airbnb.io/) [[@mistercrunch](https://github.com/mistercrunch), [@artwr](https://github.com/artwr)]
1. [AdBOOST](https://www.adboost.sk) [[AdBOOST](https://github.com/AdBOOST)]
Copy link
Contributor

@r39132 r39132 May 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It occurs to me that Airbnb should not be on the top of this list...
Can you move Airbnb to the 3rd position?

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
Closes apache#3362 from matejkloska/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants