Skip to content

Refactor: Use tmp_path in breeze/tests #33739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Aug 27, 2023
Merged

Refactor: Use tmp_path in breeze/tests #33739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions dev/breeze/tests/test_run_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
# under the License.
from __future__ import annotations

import os
import stat
from pathlib import Path

from airflow_breeze.utils.run_utils import (
change_directory_permission,
Expand All @@ -27,17 +25,19 @@
)


def test_change_file_permission(tmpdir):
tmpfile = Path(tmpdir, "test.config")
def test_change_file_permission(tmp_path):
tmpfile = tmp_path / "test.config"
tmpfile.write_text("content")
change_file_permission(tmpfile)
mode = os.stat(tmpfile).st_mode
mode = tmpfile.stat().st_mode
assert not (mode & stat.S_IWGRP) and not (mode & stat.S_IWOTH)


def test_change_directory_permission(tmpdir):
change_directory_permission(tmpdir)
mode = os.stat(tmpdir).st_mode
def test_change_directory_permission(tmp_path):
subdir = tmp_path / "testdir"
subdir.mkdir()
change_directory_permission(subdir)
mode = subdir.stat().st_mode
assert (
not (mode & stat.S_IWGRP)
and not (mode & stat.S_IWOTH)
Expand Down