ECSTaskOperator - Change default behavior for max attempts#33782
Closed
SBurwash wants to merge 2 commits intoapache:mainfrom
Closed
ECSTaskOperator - Change default behavior for max attempts#33782SBurwash wants to merge 2 commits intoapache:mainfrom
SBurwash wants to merge 2 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Member
|
There is already an open PR (#33712) to fix this issue. If you have any comment or suggestion, you can review it. I close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day!
I'd like to make a small modification to the EcsTaskOperator's default behavior to ensure that the task does not time out after 10 minutes.
Historically, the ECSTaskOperator would by default set its waiters'
max_attempslimit tosys.maxsize. However, this was changed to a default of 10 minutes(waiter_max_attemps * waiter_delay) = 100 * 6 = 600s = 10 minutes(see PR where behavior changed).To amend this, we:
waiter_max_attemptsfor the ECSTaskOperator from 100 tosys.maxsizeThanks to @vincbeck for the input on the changes.