Run back-reference breeze command as part of our CI builds#33791
Merged
potiuk merged 3 commits intoapache:mainfrom Aug 27, 2023
Merged
Run back-reference breeze command as part of our CI builds#33791potiuk merged 3 commits intoapache:mainfrom
potiuk merged 3 commits intoapache:mainfrom
Conversation
The `back-reference` command post-processes our docuementation to add redirections for new pages in the old documentation, so that user browsing the page can change version without hittin 404 error. This command was not run in CI and some refactorings could break it (as it already happened in apache#33626 - fixed by apache#33790). Most other breeze commands are already run in CI, so this one should be no different. This PR adds back-reference generation as part of our regular documentation building step.
amoghrajesh
approved these changes
Aug 27, 2023
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Makes sense to add this in the CI. One super nit, which you can feel free to ignore. Looks good +1
eladkal
approved these changes
Aug 27, 2023
Member
Author
|
Looks good. Added @amoghrajesh suggestion. I also changed print() commands to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
back-referencecommand post-processes our docuementation to add redirections for new pages in the old documentation, so that user browsing the page can change version without hittin 404 error.This command was not run in CI and some refactorings could break it (as it already happened in #33626 - fixed by #33790).
Most other breeze commands are already run in CI, so this one should be no different.
This PR adds back-reference generation as part of our regular documentation building step.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.