Skip to content

Comments

Add decorator for suppress optional internal methods in Amazon Provider#34034

Merged
potiuk merged 1 commit intoapache:mainfrom
Taragolis:amazon-simplified-exceptions
Sep 3, 2023
Merged

Add decorator for suppress optional internal methods in Amazon Provider#34034
potiuk merged 1 commit intoapache:mainfrom
Taragolis:amazon-simplified-exceptions

Conversation

@Taragolis
Copy link
Contributor

Initially I've plan only refactor _generate_dag_key by use internal generate_uuid and found that if some error occurs in the future in generate_uuid then it might affects some users.

As final result I decorate all non-main-functional methods by return_on_error, so we don't need to put all function code inside of try.. except Exception.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Sep 2, 2023
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes perfect sense.

@potiuk potiuk merged commit bf2d411 into apache:main Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants