Refactor: Simplify string generation in providers#34221
Closed
eumiro wants to merge 1 commit intoapache:mainfrom
Closed
Refactor: Simplify string generation in providers#34221eumiro wants to merge 1 commit intoapache:mainfrom
eumiro wants to merge 1 commit intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon
eumiro
requested review from
eladkal,
hussein-awala,
jedcunningham and
o-nikolas
as code owners
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
urlsplit and urlencode are great, but sometimes their result is unexpected. IMHO we need to add tests for these changes.
Comment on lines
-169
to
+172
| path = path.replace("s3://", "") | ||
| split_path = path.split("/") | ||
| return Dataset(namespace=f"s3://{split_path[0]}", name="/".join(split_path[1:]), facets={}) | ||
| split = urlsplit(path) | ||
| name = urlunsplit(split._replace(scheme="", netloc="")).lstrip("/") | ||
| return Dataset(namespace=f"{split.scheme}://{split.netloc}", name=name, facets={}) |
Member
There was a problem hiding this comment.
IMHO this kind of refactor is not safe, a unit test should be added to test it.
Comment on lines
-127
to
+128
| extras_length = len(conn.extra_dejson) | ||
| if not extras_length: | ||
| return uri | ||
|
|
||
| uri += "?" | ||
|
|
||
| for arg_key, arg_value in conn.extra_dejson.items(): | ||
| extras_length -= 1 | ||
| uri += f"{arg_key}={arg_value}" | ||
|
|
||
| if extras_length: | ||
| uri += "&" | ||
| if conn.extra_dejson: | ||
| uri += "?" + parse.urlencode(conn.extra_dejson) |
Contributor
|
ping @eumiro can you address comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.