Merged
Conversation
boring-cyborg
bot
added
area:API
uranusjr
reviewed
Sep 11, 2023
uranusjr
reviewed
Sep 11, 2023
eumiro
force-pushed
the
loops-20230908
branch
from
c0df3b3 to
71c8aa5
Compare
eumiro
force-pushed
the
loops-20230908
branch
2 times, most recently
from
fd3cde5 to
6047b2c
Compare
uranusjr
reviewed
Sep 12, 2023
Member
There was a problem hiding this comment.
I think the count_prs variable is always the same as limit_pr_count (except for 0 but that value doesn’t make practical sense anyway)
Contributor
Author
There was a problem hiding this comment.
limit_pr_count can be None and we want to print the count_prs anyway, so I changed it back to real len(prs) if limit_pr_count is None.
eumiro
force-pushed
the
loops-20230908
branch
from
6047b2c to
331bfb0
Compare
uranusjr
reviewed
Sep 13, 2023
eumiro
force-pushed
the
loops-20230908
branch
from
331bfb0 to
21dd79e
Compare
uranusjr
approved these changes
Sep 14, 2023
eumiro
force-pushed
the
loops-20230908
branch
from
21dd79e to
71a8389
Compare
Lee-W
approved these changes
Sep 15, 2023
potiuk
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.