Establishing short hand argument for apache-airflow-providers rule#34230
Merged
potiuk merged 3 commits intoapache:mainfrom Sep 9, 2023
Merged
Establishing short hand argument for apache-airflow-providers rule#34230potiuk merged 3 commits intoapache:mainfrom
potiuk merged 3 commits intoapache:mainfrom
Conversation
amoghrajesh
requested review from
ashb,
jedcunningham and
potiuk
as code owners
Contributor
Author
potiuk
reviewed
Sep 9, 2023
BREEZE.rst
Outdated
| Example: | ||
| If the provider name is ``apache-airflow-providers-cncf-kubernetes``, it will be ``cncf.kubernetes``. | ||
|
|
||
| Note: For building docs for apache-airflow-providers index, use dot``(.)`` as short hand operator. |
Member
There was a problem hiding this comment.
Maybe providers is a better choice?
Member
There was a problem hiding this comment.
Or providers-index ? (Since we have all-providers already.
Member
There was a problem hiding this comment.
I don't think the dot is the best choice. providers-index looks better.
Contributor
Author
There was a problem hiding this comment.
Sure sure, makes sense
potiuk
approved these changes
Sep 9, 2023
eladkal
approved these changes
Sep 9, 2023
hussein-awala
approved these changes
Sep 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding ability to use short hand for apache-airflow-providers rule also. You can now use a
providers-indexfor that rule without the package filter.Example:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.