Skip to content

full screen mode for logs#34233

Closed
Abhishek-kumar-ISM wants to merge 2 commits intoapache:mainfrom
Abhishek-kumar-ISM:full_screen_mode_for_logs
Closed

full screen mode for logs#34233
Abhishek-kumar-ISM wants to merge 2 commits intoapache:mainfrom
Abhishek-kumar-ISM:full_screen_mode_for_logs

Conversation

@Abhishek-kumar-ISM
Copy link
Contributor

related: #33012

As asked in above issue, i have done part of showing full screen logs.

I have added a small icon above logs on right side
minised

When one clicks on it, it will maximize log screens as follows
maximised

When one clicks it again, then it will minimize log screen, and show normal screen.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Sep 9, 2023
@Abhishek-kumar-ISM
Copy link
Contributor Author

Abhishek-kumar-ISM commented Sep 9, 2023

@Adaverse @potiuk @Taragolis @eladkal @pierrejeambrun @bbovenzi @ryanahamilton @ashb

I have added an icon that can maximize or minimize the logs to full screen.
I have verified it in chrome, firefox and edge, everywhere working.

Please check and review.

@pierrejeambrun
Copy link
Member

Hello,

Please don't @ directly people unless there is a specific reason to ping someone. Code owners are automatically asked for a review and most maintainers have subscribed to notifications and will be notified on each activity (PR/issue/dicussion/etc.). People will review in time.

Thank you for the PR, looking cool!

@Abhishek-kumar-ISM
Copy link
Contributor Author

Hello,

Please don't @ directly people unless there is a specific reason to ping someone. Code owners are automatically asked for a review and most maintainers have subscribed to notifications and will be notified on each activity (PR/issue/dicussion/etc.). People will review in time.

Thank you for the PR, looking cool!

Okay sorry, i was not aware about that.

@Adaverse
Copy link
Contributor

This is same functionality as F11. The issue highlighted the need for bigger view for logs in GRID view. This screen will be removed in coming days. Correct me if I'm mistaken @bbovenzi

@bbovenzi
Copy link
Contributor

This is same functionality as F11. The issue highlighted the need for bigger view for logs in GRID view. This screen will be removed in coming days. Correct me if I'm mistaken @bbovenzi

That's right. I would avoid making changes to this logs page as it will almost certainly be removed in 2.8
But I'm happy to review any improvements to the logs in grid view.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 29, 2023
@github-actions github-actions bot closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants