Correct parameter names in docstring for S3CreateObjectOperator#34263
Merged
vincbeck merged 2 commits intoapache:mainfrom Sep 11, 2023
Merged
Correct parameter names in docstring for S3CreateObjectOperator#34263vincbeck merged 2 commits intoapache:mainfrom
vincbeck merged 2 commits intoapache:mainfrom
Conversation
Currently the parameter descriptions for `S3CreateObjectOperator` reference old(?) parameter names: > s3_bucket (str | None) – Name of the S3 bucket where to save the object. (templated) It should be omitted when ~~bucket_key~~ **s3_key** is provided as a full s3:// url. > s3_key (str) – The key of the object to be created. (templated) It can be either full s3:// style url or relative path from root level. When it’s specified as a full s3:// url, please omit ~~bucket_name~~ **s3_bucket**.
boring-cyborg
bot
added
area:providers
provider:amazon
uranusjr
reviewed
Sep 11, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
hussein-awala
approved these changes
Sep 11, 2023
vincbeck
approved these changes
Sep 11, 2023
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the parameter descriptions for
S3CreateObjectOperatorreference old(?) parameter names:^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.