[AIRFLOW-2504] Log username correctly and Add extra to search columns

[youngyjd]

Make sure you have checked all steps below.

JIRA

• My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-2504
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a JIRA issue.

Description

• Here are some details about my PR, including screenshots of any UI changes:

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

• Passes git diff upstream/master -u -- "*.py" | flake8 --diff

[codecov-io]

Codecov Report

Merging #3438 into master will not change coverage.
The diff coverage is 75%.

@@           Coverage Diff           @@
##           master    #3438   +/-   ##
=======================================
  Coverage   76.75%   76.75%           
=======================================
  Files         203      203           
  Lines       15100    15100           
=======================================
  Hits        11590    11590           
  Misses       3510     3510

Impacted Files	Coverage Δ
airflow/www/views.py	71.99% <100%> (ø)	⬆️
airflow/www_rbac/views.py	74.56% <100%> (ø)	⬆️
airflow/www/utils.py	86.33% <50%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6cdc8...1ce098d. Read the comment docs.

[kaxil]

Can you please squash commits?

[jgao54]

good catch! this seems like a bug and I wonder if we can remove this completely given it's always None.

[youngyjd]

We use google authentication and current_user.username is always None, but I am not sure whether there is any other use cases or authentication methods that current_user.username is not None. I did a quick code search for current_user.username and it looks like there are some usage of current_user.username in UI. What do you think?

[jgao54]

Ah yeah, looks like the use case is trivial (airflow logo title) in the main UI, and it's currently returning None when you hover your mouse over it, so it can be replaced as well :)

[youngyjd]

Sure. Will replace that part as well. Thanks

[youngyjd]

@jgao54 Done. I checked current_user.username for the rbac UI and it worked fine. I assume the bug only exits in the old UI.

[youngyjd]

@kaxil sure. I though it was better to have 2 separate commits.. I will squash them

[jgao54]

Could you prepend your commit with [AIRFLOW-XXX], will merge after.

[youngyjd]

Cannot simply change title="{{ current_user.username }}" to title="{{ current_user.user.username }}" because tests will fail. The AnonymousUserMixin() object does not have user attribute while DefaultUser(), GoogleUser(), etc have.

[jgao54]

ah i see! thanks for digging.

[feng-tao]

does this pr need to change for the rbac UI(under www_rbac directory)? @youngyjd

[youngyjd]

@feng-tao rbac is using flask g, which works fine.