Reduce round trips to db when evaluating setup tasks#34578
Closed
dstandish wants to merge 1 commit intoapache:mainfrom
Closed
Reduce round trips to db when evaluating setup tasks#34578dstandish wants to merge 1 commit intoapache:mainfrom
dstandish wants to merge 1 commit intoapache:mainfrom
Conversation
Ensuring that cleared tasks wait for indirect setup tasks was fixed in apache#33903. That fix entailed applying logic similar to ALL_SUCCESS logic for just the indirect upstream tasks before moving on to the evaluation of direct upstreams. This had the benefit of similicity and isolation -- it would only be called for tasks that had indirect upstreams and it would be layered on top of the existing trigger rule dep logic -- not mixed in. But it resulted in new round trips to the db when there is an indirect setup. What this PR does is try to get all the upstream TI info in one query.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensuring that cleared tasks wait for indirect setup tasks was fixed in #33903. That fix entailed applying logic similar to ALL_SUCCESS logic for just the indirect upstream tasks before moving on to the evaluation of direct upstreams.
This had the benefit of similicity and isolation -- it would only be called for tasks that had indirect upstreams and it would be layered on top of the existing trigger rule dep logic -- not mixed in.
But it resulted in new round trips to the db when there is an indirect setup.
What this PR does is try to get all the upstream TI info in one query.