Skip to content

Fix warnings aws providers s3 hook tests#34581

Merged
hussein-awala merged 3 commits intoapache:mainfrom
josekidengan:fix_warnings_s3_hook_tests
Sep 24, 2023
Merged

Fix warnings aws providers s3 hook tests#34581
hussein-awala merged 3 commits intoapache:mainfrom
josekidengan:fix_warnings_s3_hook_tests

Conversation

@josekidengan
Copy link
Contributor

This MR fixes the warnings on the AWS S3 hook tests.
Connection parameters are updated to reflect the latest changes

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 24, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@hussein-awala hussein-awala merged commit 357b80f into apache:main Sep 24, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 24, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@hussein-awala
Copy link
Member

Congrats on your first commit 🎉

@eladkal
Copy link
Contributor

eladkal commented Sep 24, 2023

Congrats @josekidengan
Hope to see more of your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants