Skip to content

Correct docs for multi-value select#34690

Merged
jedcunningham merged 1 commit intoapache:mainfrom
jamesqo:patch-1
Sep 30, 2023
Merged

Correct docs for multi-value select#34690
jedcunningham merged 1 commit intoapache:mainfrom
jamesqo:patch-1

Conversation

@jamesqo
Copy link
Contributor

@jamesqo jamesqo commented Sep 29, 2023

The correct attribute name is examples, not example.

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 29, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jedcunningham jedcunningham added this to the Airflow 2.7.2 milestone Sep 30, 2023
@jedcunningham jedcunningham merged commit 8e93586 into apache:main Sep 30, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 30, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@jedcunningham
Copy link
Member

Thanks @jamesqo! Congrats on your first commit 🎉

@jamesqo jamesqo deleted the patch-1 branch September 30, 2023 00:14
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants