Remove unused method _discover_hooks_from_hook_class_names#34777
Closed
utkarsharma2 wants to merge 2 commits intoapache:mainfrom
Closed
Remove unused method _discover_hooks_from_hook_class_names#34777utkarsharma2 wants to merge 2 commits intoapache:mainfrom
_discover_hooks_from_hook_class_names#34777utkarsharma2 wants to merge 2 commits intoapache:mainfrom
Conversation
utkarsharma2
force-pushed
the
Remove_method_hook_class_names
branch
from
c628de7 to
f3d8380
Compare
Contributor
|
This attribute removed in Community providers but core should support legacy |
Contributor
Author
|
@Taragolis Ya, that makes sense, thanks for the context. I'll close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we no longer have the
hook-class-namesproperty inprovider.yamlas removed in the PR - #24702 we no longer need_discover_hooks_from_hook_class_namesmethods as well.