Skip to content

Comments

Corrected the user creation command CONTRIBUTORS_QUICK_START.rst#34842

Merged
potiuk merged 9 commits intoapache:mainfrom
KesharwaniArpita:patch-2
Oct 18, 2023
Merged

Corrected the user creation command CONTRIBUTORS_QUICK_START.rst#34842
potiuk merged 9 commits intoapache:mainfrom
KesharwaniArpita:patch-2

Conversation

@KesharwaniArpita
Copy link
Contributor

No description provided.

Copy link
Contributor

@utkarsharma2 utkarsharma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me once the @Lee-W Suggestion is merged. Thanks for the contribution @KesharwaniArpita. :)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@KesharwaniArpita
Copy link
Contributor Author

Thanks for the review, I have made the required change.

Co-authored-by: Jens Scheffler <95105677+jens-scheffler-bosch@users.noreply.github.com>
@jscheffl
Copy link
Contributor

FYI Pipeline fails but unfortunately (at least for me) the logs do not show details, error that I can see in raw logs are:

2023-10-11T15:03:03.3370615Z Remove trailing whitespace at end of line..........................................�[41mFailed�[m
2023-10-11T15:03:03.3371785Z �[2m- hook id: trailing-whitespace�[m
2023-10-11T15:03:03.3372355Z �[2m- exit code: 1�[m
2023-10-11T15:03:03.3373111Z �[2m- files were modified by this hook�[m
2023-10-11T15:03:03.3373545Z
2023-10-11T15:03:03.3373799Z Fixing CONTRIBUTORS_QUICK_START.rst
2023-10-11T15:03:03.3374137Z

@KesharwaniArpita
Copy link
Contributor Author

I cannot understand what do you meant by that?

@jscheffl
Copy link
Contributor

I cannot understand what do you meant by that?

The PR failed build and can not be merged. In my brwoser the logs failed to display. THe log part I posted above is the error message: There are tailing spaces in the RST changes you made.

@utkarsharma2
Copy link
Contributor

@KesharwaniArpita
Copy link
Contributor Author

Thanks for letting me know. Can you try again?

@KesharwaniArpita
Copy link
Contributor Author

@KesharwaniArpita You might want to install pre-commits hooks - https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#pre-commit-hooks

Yeah, Thank you!

KesharwaniArpita and others added 3 commits October 17, 2023 09:34
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@potiuk potiuk merged commit bbb04bf into apache:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants