[AIRFLOW-2601] Allow user to specify k8s config#3491
[AIRFLOW-2601] Allow user to specify k8s config#3491Noremac201 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Can you add some tests? |
Codecov Report
@@ Coverage Diff @@
## master #3491 +/- ##
=======================================
Coverage 77.14% 77.14%
=======================================
Files 203 203
Lines 15123 15123
=======================================
Hits 11667 11667
Misses 3456 3456Continue to review full report at Codecov.
|
f6d6513 to
84afff5
Compare
|
My Travis CI is passing: |
|
Code-wise this looks fine to me. You could test this by adding a travis step that copies the kubeconfig to an arbitrary folder and then running a test that points to that arbitrary kubeconfig. Also it looks like your travis build is failing (might need to rebase) |
|
@Noremac201 Can you add the test @dimberman is suggesting? Once that is done I am happy to merge this. |
|
I believe I've added the test that was asked for. If not let me know how I should've done it. Thank you |
|
@Noremac201 Test looks good, I'm seeing the travis as failing but the failure looks unrelated to your changed. @kaxil LGTM |
Closes apache#3491 from Noremac201/config_kube
This adds the ability in the Kubernetes operator to specify the config file, if it is different than default.
JIRA
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff