Skip to content

[AIRFLOW-2601] Allow user to specify k8s config#3491

Closed
Noremac201 wants to merge 1 commit intoapache:masterfrom
Noremac201:config_kube
Closed

[AIRFLOW-2601] Allow user to specify k8s config#3491
Noremac201 wants to merge 1 commit intoapache:masterfrom
Noremac201:config_kube

Conversation

@Noremac201
Copy link
Contributor

This adds the ability in the Kubernetes operator to specify the config file, if it is different than default.

JIRA

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@kaxil
Copy link
Member

kaxil commented Jun 12, 2018

Can you add some tests?

@codecov-io
Copy link

Codecov Report

Merging #3491 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3491   +/-   ##
=======================================
  Coverage   77.14%   77.14%           
=======================================
  Files         203      203           
  Lines       15123    15123           
=======================================
  Hits        11667    11667           
  Misses       3456     3456

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff8318...734c55c. Read the comment docs.

@Noremac201 Noremac201 force-pushed the config_kube branch 2 times, most recently from f6d6513 to 84afff5 Compare June 13, 2018 23:38
@Noremac201
Copy link
Contributor Author

@dimberman
Copy link
Contributor

Code-wise this looks fine to me. You could test this by adding a travis step that copies the kubeconfig to an arbitrary folder and then running a test that points to that arbitrary kubeconfig. Also it looks like your travis build is failing (might need to rebase)

@kaxil
Copy link
Member

kaxil commented Jun 15, 2018

@Noremac201 Can you add the test @dimberman is suggesting? Once that is done I am happy to merge this.

@Noremac201
Copy link
Contributor Author

I believe I've added the test that was asked for. If not let me know how I should've done it.
Travis passed on my branch:
https://travis-ci.org/Noremac201/incubator-airflow/builds/393725214

Thank you

@dimberman
Copy link
Contributor

@Noremac201 Test looks good, I'm seeing the travis as failing but the failure looks unrelated to your changed.

@kaxil LGTM

@asfgit asfgit closed this in 14a77a7 Jun 18, 2018
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants