Unflake test_volume_mount in k8s tests#35106
Merged
potiuk merged 1 commit intoapache:mainfrom Oct 22, 2023
Merged
Conversation
boring-cyborg
bot
added
the
provider:cncf-kubernetes
Member
Author
|
Example flaky failure here: https://github.com/apache/airflow/actions/runs/6598526836/job/17926985195 |
potiuk
requested review from
amoghrajesh,
bolkedebruin,
ephraimbuddy,
hussein-awala and
uranusjr
The `test_volume_mount` in k8s relied on "retrieved from mount\n" printed to log as retrieved from K8S pod. Howver, due to the way how logs are retrieved, sometimes the log printed contains the EOL character and sometimes not - depending on when the strings are flushed. This PR changes the test to passs regardless if EOL is included in the log or not.
potiuk
force-pushed
the
unflake-volume-mount-k8s-test
branch
from
9043b62 to
e6c588c
Compare
hussein-awala
approved these changes
Oct 22, 2023
Contributor
|
Makes sense |
amoghrajesh
approved these changes
Oct 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_volume_mountin k8s relied on "retrieved from mount\n" printed to log as retrieved from K8S pod. Howver, due to the way how logs are retrieved, sometimes the log printed contains the EOL character and sometimes not - depending on when the strings are flushed. This PR changes the test to passs regardless if EOL is included in the log or not.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.