Remove "post-tests" steps for Helm Unit tests in CI#35437
Merged
potiuk merged 1 commit intoapache:mainfrom Nov 4, 2023
Merged
Conversation
The "Helm Unit Tests" are special case of tests - they do not run airflow code, they are merely runnig `helm` to process the chart templates with various combinations of parameters. As such, they do not contribute to coverage of Airflow Python code, and they do not generate warnings when the code is run so there is no point in attempting to upload coverage and warnings after the tests complete. This even generates warnings currently in Job summary: > Unit tests Helm: other > No files were found with the provided path: ./files/warnings-*.txt. No > artifacts will be uploaded. There is no real cleanup we need after those tests because we are not running containers during those tests, so we can safely just remove cleanup steps - not even fix-ownership that helps to deal with files that are created with root owner during container based jobs.
Member
Author
|
That should remove the last warnings we have in CI job outputs - leaving only useful information (artifacts and dump of constratints upgrade) in the Job summary:
|
hussein-awala
approved these changes
Nov 4, 2023
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
The "Helm Unit Tests" are special case of tests - they do not run airflow code, they are merely runnig `helm` to process the chart templates with various combinations of parameters. As such, they do not contribute to coverage of Airflow Python code, and they do not generate warnings when the code is run so there is no point in attempting to upload coverage and warnings after the tests complete. This even generates warnings currently in Job summary: > Unit tests Helm: other > No files were found with the provided path: ./files/warnings-*.txt. No > artifacts will be uploaded. There is no real cleanup we need after those tests because we are not running containers during those tests, so we can safely just remove cleanup steps - not even fix-ownership that helps to deal with files that are created with root owner during container based jobs.
ephraimbuddy
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Helm Unit Tests" are special case of tests - they do not run airflow code, they are merely runnig
helmto process the chart templates with various combinations of parameters. As such, they do not contribute to coverage of Airflow Python code, and they do not generate warnings when the code is run so there is no point in attempting to upload coverage and warnings after the tests complete. This even generates warnings currently in Job summary:There is no real cleanup we need after those tests because we are not running containers during those tests, so we can safely just remove cleanup steps - not even fix-ownership that helps to deal with files that are created with root owner during container based jobs.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.